[PATCH] D70582: [FPEnv][X86] Constrained FCmp intrinsics enabling on X86

Pengfei Wang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Dec 10 04:12:17 PST 2019


pengfei added a comment.

In D70582#1776752 <https://reviews.llvm.org/D70582#1776752>, @uweigand wrote:

> > signaling->signalling
>
> Not to be too nitpicky, but I've been using the US spelling (with one 'l') in the common code parts of the patch :-)  Should we be consistent here?


I found IEEE754 uses signaling, I think it's better to follow it as well as common code.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70582/new/

https://reviews.llvm.org/D70582





More information about the llvm-commits mailing list