[PATCH] D71065: [ARM][MVE] Add intrinsics for immediate shifts.

[Simon Tatham via Phabricator via llvm-commits]

simon_tatham updated this revision to Diff 233025.
simon_tatham added a comment.

Changes from previous version:

- minor cleanup: removed check of `hasIntegerConstantValue` in `IRBuilderResult::more_prerequisites`, which was causing the generated codegen to perofrm a pointless call to `EmitScalarExpr` whose result was thrown away.

- incorporated NEON test failure fix from rG8d70f3c933a5b81a <https://reviews.llvm.org/rG8d70f3c933a5b81a87a5ab1af0e3e98ee2cd7c67>

- incorporated the `-Winconsistent-missing-override` fix from rGff4dceef9201c5ae <https://reviews.llvm.org/rGff4dceef9201c5ae3924e92f6955977f243ac71d>

- did not incorporate the `-Wunused-variable` change from rGff4dceef9201c5ae <https://reviews.llvm.org/rGff4dceef9201c5ae3924e92f6955977f243ac71d> which moved a side-effecting function call into an assert statement. Instead fixed it with a `(void)IsConst` like all the other call sites.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71065/new/

https://reviews.llvm.org/D71065

Files:
  clang/include/clang/Basic/arm_mve.td
  clang/include/clang/Basic/arm_mve_defs.td
  clang/lib/CodeGen/CGBuiltin.cpp
  clang/test/CodeGen/arm-mve-intrinsics/vector-shift-imm.c
  clang/utils/TableGen/MveEmitter.cpp
  llvm/include/llvm/IR/IntrinsicsARM.td
  llvm/lib/Target/ARM/ARMInstrMVE.td
  llvm/test/CodeGen/Thumb2/mve-intrinsics/vector-shift-imm.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71065.233025.patch
Type: text/x-patch
Size: 58014 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191210/7293f91c/attachment-0001.bin>