[PATCH] D71118: [llvm-readelf/llvm-readobj] - Improved the error reporting in a few method related to versioning.

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: llvm/test/tools/llvm-readobj/elf-versym-invalid.test:256
+    Type:    SHT_GNU_versym
+    Entries: [ 0xFF, 0xFE ]
+DynamicSymbols:
----------------
jhenderson wrote:
> grimar wrote:
> > jhenderson wrote:
> > > Would it be worth an extra 0xFF entry to show that the warning gets uniqued?
> > Done.
> Will you need an --implicit-check-not="warning:" or equivalent somewhere to actually detect that the warning has actually been uniqued?
Oh, I missed we do not have it.
And also actually we need one more dynamic symbol to trigger a warning too..
I've updated the test.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71118/new/

https://reviews.llvm.org/D71118