[PATCH] D70582: [FPEnv][X86] Constrained FCmp intrinsics enabling on X86

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/TargetLowering.h:2099
+                         LegalizeAction Action,
+                         ActionIndex AI = ActionIndex::Both) {
+    assert(VT.isValid() && (unsigned)CC < array_lengthof(CondCodeActions[0]) &&
----------------
pengfei wrote:
> craig.topper wrote:
> > Are we using the new support you've added here in this patch? If its not needed by X86 it doesn't belong in this patch.
> Yes. We are using it for CCs `SETOEQ` and `SETUNE` in all scalar FP types.
But I couldn't find any modified calls to setCondCodeAction, so aren't we just always passing "Both"?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70582/new/

https://reviews.llvm.org/D70582