[PATCH] D71203: [llvm-readobj][test] - Move platform specific test cases and their inputs to separate folders.

Mon Dec 9 23:30:33 PST 2019

grimar marked an inline comment as done.
grimar added a comment.

In D71203#1775288 <https://reviews.llvm.org/D71203#1775288>, @jhenderson wrote:

> This change makes me very happy, LGTM.
>
> I think an obvious follow-up would be to split the multi-format tests up into separate tests.

Yeah, that is my plan.

================
Comment at: llvm/test/tools/llvm-objdump/elf-dynamic-section-machine-specific.test:3
 # RUN: yaml2obj --docnum=1 -o %t.hex \
-# RUN:          %S/../llvm-readobj/Inputs/elf-dynamic-tags-machine-specific.yaml
+# RUN:          %S/../llvm-readobj/ELF/Inputs/elf-dynamic-tags-machine-specific.yaml
 # RUN: llvm-objdump -p %t.hex | FileCheck %s --check-prefix=HEXAGON
----------------
jhenderson wrote:
> The fact that this test relies on an input in llvm-readobj seems a bit bizarre to me, frankly!
At least it is very inconsistent. Doesn't seem we do that in other tests.
(and having many cross references would be a big mess probably!)
It lives in "ELF/Inputs" which is my target for cleanup, so I think it will gone soon.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71203/new/

https://reviews.llvm.org/D71203