[PATCH] D71238: Align non-fused branches within 32-Byte boundary (basic case)

[annita.zhang via Phabricator via llvm-commits]

annita.zhang added a comment.

I have a general comment. I think the macro-fused jcc instructions should be taken into account even for NOP padding. From our experience, it's better to take the macro-fused instructions as an integrated instruction, and ensure it not cross or against 32-byte boundary by padding if necessary.

Given the lack of macro-fused jcc and hard copy handling in this patch, I would suggest that we base on the previous patch and split it into two, one for NOP padding and the other for prefix padding. I suppose the first one is what you desire to have. And it should cover more corner cases we met and resolved before. What do you think?

@skan


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71238/new/

https://reviews.llvm.org/D71238