[compiler-rt] 78a7af4 - Revert "[compiler-rt] Add a critical section when flushing gcov counters"

[Akira Hatanaka via llvm-commits]

Author: Akira Hatanaka
Date: 2019-12-09T19:58:26-08:00
New Revision: 78a7af456dbb8c43ab4f4616c14a78716a7c5d84

URL: https://github.com/llvm/llvm-project/commit/78a7af456dbb8c43ab4f4616c14a78716a7c5d84
DIFF: https://github.com/llvm/llvm-project/commit/78a7af456dbb8c43ab4f4616c14a78716a7c5d84.diff

LOG: Revert "[compiler-rt] Add a critical section when flushing gcov counters"

This reverts commit 88f5bf77f92899b19fdafdffc7b060f930c1cb8b as it broke
green dragon bots.

http://lab.llvm.org:8080/green/job/clang-stage1-RA/4401/

Added: 
    

Modified: 
    compiler-rt/lib/profile/GCDAProfiling.c

Removed: 
    


################################################################################
diff  --git a/compiler-rt/lib/profile/GCDAProfiling.c b/compiler-rt/lib/profile/GCDAProfiling.c
index 93d226fc3395..498c05900bf2 100644
--- a/compiler-rt/lib/profile/GCDAProfiling.c
+++ b/compiler-rt/lib/profile/GCDAProfiling.c
@@ -62,27 +62,8 @@ typedef unsigned long long uint64_t;
 #include "InstrProfiling.h"
 #include "InstrProfilingUtil.h"
 
-#ifndef _WIN32
-#include <pthread.h>
-pthread_mutex_t gcov_flush_mutex = PTHREAD_MUTEX_INITIALIZER;
-static __inline void gcov_flush_lock() {
-  pthread_mutex_lock(&gcov_flush_mutex);
-}
-static __inline void gcov_flush_unlock() {
-  pthread_mutex_unlock(&gcov_flush_mutex);
-}
-#else
-#include <windows.h>
-static SRWLOCK gcov_flush_mutex = SRWLOCK_INIT;
-static __inline void gcov_flush_lock() {
-  AcquireSRWLockExclusive(&gcov_flush_mutex);
-}
-static __inline void gcov_flush_unlock() {
-  ReleaseSRWLockExclusive(&gcov_flush_mutex);
-}
-#endif
-
 /* #define DEBUG_GCDAPROFILING */
+
 /*
  * --- GCOV file format I/O primitives ---
  */
@@ -639,16 +620,12 @@ void llvm_register_flush_function(fn_ptr fn) {
 }
 
 void __gcov_flush() {
-  gcov_flush_lock();
-
   struct fn_node* curr = flush_fn_list.head;
 
   while (curr) {
     curr->fn();
     curr = curr->next;
   }
-
-  gcov_flush_unlock();
 }
 
 COMPILER_RT_VISIBILITY