[PATCH] D70758: [PowerPC][NFC] Rename record instructions to use _record suffix instead of o

qshanz via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 9 19:08:22 PST 2019


steven.zhang added a comment.

When my first time see the suffix "o" in the opcode, it is really hard for me to know that it is record form...(o stands for .)  As mentioned before, there is no good way to use short character(such as 'o' or 'r') to indicate too much information. But we could have some information in the instruction definition if people really want to know what it is. Personally, I don't like the _record, even the _rec, as it will make the opcode longer(i.e. ANDI_record_1_GT_BIT8). I will vote for abandon if we want to change it to _rec or _record. But you can skip my opinion as I didn't have strong bias on this :)


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70758/new/

https://reviews.llvm.org/D70758





More information about the llvm-commits mailing list