[PATCH] D70724: [PowerPC] Add Support for indirect calls on AIX.
Hubert Tong via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 9 19:00:11 PST 2019
hubert.reinterpretcast added a comment.
Some minor comments; otherwise, I think this is fine, but I don't know if others believe there are still comments to be addressed.
================
Comment at: llvm/lib/Target/PowerPC/PPCInstrFormats.td:1539
+ bits<5> RST;
+ bits<21> DS_RA;
+
----------------
The naming still refers to the "DS" field for the DS-form instruction.
================
Comment at: llvm/lib/Target/PowerPC/PPCInstrFormats.td:1545
+ let Inst{11-15} = bi;
+ let Inst{16-18} = 0; // Unused (BH)
+ let Inst{19-20} = 0;
----------------
BH comprises bits 19 and 20, not bits 16 through 18.
================
Comment at: llvm/test/CodeGen/PowerPC/aix_indirect_call.ll:115
+
+; CHECKASM-LABEL: .callThroughPtrWithArgs:
+
----------------
Should we have an `OBJ32-LABEL` as well?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70724/new/
https://reviews.llvm.org/D70724
More information about the llvm-commits
mailing list