[PATCH] D71230: [llvm/dwarfdump] Use the architecture string to filter.

[Jonas Devlieghere via Phabricator via llvm-commits]

This revision was automatically updated to reflect the committed changes.
Closed by commit rGd9466653e4dd: [llvm/dwarfdump] Use the architecture string to filter. (authored by JDevlieghere).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71230/new/

https://reviews.llvm.org/D71230

Files:
  llvm/test/tools/llvm-dwarfdump/AArch64/arch.ll
  llvm/test/tools/llvm-dwarfdump/filter.test
  llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp


Index: llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
===================================================================
--- llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
+++ llvm/tools/llvm-dwarfdump/llvm-dwarfdump.cpp
@@ -271,7 +271,7 @@
           return true;
 
       // Match as name.
-      if (MachO->getArchTriple().getArch() == Triple(Arch).getArch())
+      if (MachO->getArchTriple().getArchName() == Triple(Arch).getArchName())
         return true;
     }
   }
Index: llvm/test/tools/llvm-dwarfdump/filter.test
===================================================================
--- /dev/null
+++ llvm/test/tools/llvm-dwarfdump/filter.test
@@ -0,0 +1,4 @@
+Make sure that passing --arch armv7s only shows the armv7s slice and not the armv7 slice.
+
+RUN: llvm-dwarfdump -arch armv7s %S/../dsymutil/Inputs/fat-test.arm.dylib | FileCheck %s
+CHECK-NOT: (armv7)
Index: llvm/test/tools/llvm-dwarfdump/AArch64/arch.ll
===================================================================
--- llvm/test/tools/llvm-dwarfdump/AArch64/arch.ll
+++ llvm/test/tools/llvm-dwarfdump/AArch64/arch.ll
@@ -1,6 +1,5 @@
 ; RUN: llc -O0 %s -filetype=obj -o %t.o
 ; RUN: llvm-dwarfdump -arch arm64   %t.o | FileCheck %s
-; RUN: llvm-dwarfdump -arch aarch64 %t.o | FileCheck %s
 ; RUN: llvm-dwarfdump -arch 0x0100000c %t.o | FileCheck %s
 ; CHECK: file format Mach-O arm64
 ;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71230.232978.patch
Type: text/x-patch
Size: 1364 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191210/bc8265a9/attachment.bin>