[PATCH] D70738: [libFuzzer] Add custom output function

[Manish Goregaokar via Phabricator via llvm-commits]

Manishearth added a comment.



> 3. if a crash happens, execute `LPM_DUMP_NATIVE_INPUT=1 ./binary <crash_input>` to get the input fancy printed

Ah, I didn't know the binary could be used this way. Still, it's a bit annoying to have to parse the crash lines and hope that format never changes.

> Writing `if getenv()` statement is not harder then writing a new function. Maintaining that solution costs 0 for libFuzzer upstream and any other libFuzzer users.

I think I'd misunderstood your suggestion. It seems we'd be able to stick the getenv call at the top of the macro, I was saying that we don't want the _user_ to ever have to write this.

> To write LLVMFuzzerCustomOutput function, you would need to either duplicate that data break up logic, or introduce another function for splitting the data and passing the objects around.

We're using an autogenerated trait for this anyway, so we get this for free.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70738/new/

https://reviews.llvm.org/D70738