[PATCH] D71158: [NFC][InstSimplify] Refactoring ThreadCmpOverSelect function

Mon Dec 9 16:48:10 PST 2019

xbolva00 added a comment.

This looks fine I think.

================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:158
+/// Simplify comparison with true branch of select
+static Value *simplifyCmpSelTrueCase(CmpInst::Predicate Pred, Value *LHS,
+                                     Value *RHS, Value *Cond,
----------------
dendibakh wrote:
> xbolva00 wrote:
> > btw, do you plan to use this helper functions in a future patch? For now, I dont think we really need them in this patch.
> > btw, do you plan to use this helper functions in a future patch?
> Yes
> 
> > For now, I dont think we really need them in this patch.
> Well, I believe it makes the code a little bit cleaner anyway. :)
> 
> 
Ok, it is fine.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71158/new/

https://reviews.llvm.org/D71158