[PATCH] D70859: [BUG-FIX][XCOFF] fixed a bug of XCOFFObjectFile.cpp when there is padding at the last csect of a sections

[Hubert Tong via Phabricator via llvm-commits]

hubert.reinterpretcast accepted this revision.
hubert.reinterpretcast added a comment.

LGTM with minor comments.



================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:360
     assert(CurrentAddressLocation == Section->Address &&
-           "We should have no padding between sections.");
+           "Sections should be written consecutively");
     for (const auto *Group : Section->Groups) {
----------------
Minor nit: We have been using periods to end full sentences in asserts. Add a period here.


================
Comment at: llvm/test/CodeGen/PowerPC/aix-xcoff-mergeable-str.ll:11
 
+; RUN: llc -verify-machineinstrs -mcpu=pwr7 -mtriple powerpc-ibm-aix-xcoff -filetype=obj -o %t.o  < %s
+; RUN: llvm-objdump -D %t.o | FileCheck --check-prefix=CHECKOBJ %s
----------------
Minor nit: We did not use two spaces before the `< %s` on the lines above. Let's not use it here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70859/new/

https://reviews.llvm.org/D70859