[PATCH] D71182: [NFC][llvm][MIRVRegNamerUtils] Making some stylistic changes to MIRVRegNamerUtils.cpp
Aditya Nandakumar via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 9 16:01:24 PST 2019
aditya_nandakumar added inline comments.
================
Comment at: llvm/lib/CodeGen/MIRVRegNamerUtils.cpp:132
return MRI.createVirtualRegister(RC, Temp);
return MRI.createGenericVirtualRegister(MRI.getType(VReg), Name);
}
----------------
plotfi wrote:
> @aditya_nandakumar do you remember the reason that in the RC case we are using the lower case name but in the typed case we are creating a generic vreg but not lower casing the name? I don't remember this. Might put a comment in here for that.
I was only dealing with non generic vregs (post selection) - I didn't plan on using this mid GIsel pipeline - please update that as well while you can.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71182/new/
https://reviews.llvm.org/D71182
More information about the llvm-commits
mailing list