[PATCH] D71219: Fix conflict value for metadata "Objective-C Garbage Collection" in the mix of swift and Objective-C bitcode

Steven Wu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 9 15:21:32 PST 2019


steven_wu added a comment.

Breaking part the meta data sounds like a good idea. You will probably need to combine the value in the backend to generate the field in the object file.

Also, please add test case. If you go down the route of splitting the value, you need:

- codegen tests for correct value in the object file
- llvm-link tests for combining objc and swift bitcode
- auto upgrade test if you want to support the old bitcode


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71219/new/

https://reviews.llvm.org/D71219





More information about the llvm-commits mailing list