[PATCH] D71182: [NFC][llvm][MIRVRegNamerUtils] Making some stylistic changes to MIRVRegNamerUtils.cpp
Puyan Lotfi via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Dec 9 15:03:30 PST 2019
plotfi added a comment.
In D71182#1775875 <https://reviews.llvm.org/D71182#1775875>, @compnerd wrote:
> The `std::transform` better expresses the intent IMO. I think that it is definitely more idiomatic C++, so I think that is an improvement.
I agree with this. Was going through the changes in this util in my downtime and just saw some opportunities to spruce some things up. I find it really odd that you'd have a HashOperand lambda and not want to apply that to your collection of uses from a llvm::transform.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71182/new/
https://reviews.llvm.org/D71182
More information about the llvm-commits
mailing list