[PATCH] D71148: [hwasan] Offline symbolization script.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis marked an inline comment as done.
eugenis added inline comments.


================
Comment at: compiler-rt/lib/hwasan/scripts/hwasan_symbolize:119
+  #0 0x7f6e35cf2e45  (/blah/foo.so+0x11fe45)
+  match = re.match(r'^(.*?)#([0-9]+)( *)(0x[0-9a-f]+) *\((.*)\+(0x[0-9a-f]+)\)', line, re.UNICODE)
+  if match:
----------------
hctim wrote:
> I think a lot of `.*?`'s here can be replaced with `\s*` for stability:
> 
> `(\s*)#(\d+)\s*(0x[0-9a-f]+)\s*\((.*)\+(0x[0-9a-f]+)\)`
Not really. The first one needs to accept any prefix, like timestamp in adb logcat.
The second and the third have to be actual whitespace, we print it ourselves.



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71148/new/

https://reviews.llvm.org/D71148