[PATCH] D70456: [Matrix] Add first set of matrix intrinsics and initial lowering pass.

[Adam Nemet via Phabricator via llvm-commits]

anemet added inline comments.


================
Comment at: llvm/docs/LangRef.rst:14491-14492
+
+The <Rows> and <Cols> arguments must be constant integers. The returned vector
+must have <Rows> * <Cols> elements. %Stride must be >= <Rows>.
+
----------------
We should also be explicit that the unit for %Stride is also the element type.  "Distance" above is a bit ambiguous. 

The rest of the new changes look good.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70456/new/

https://reviews.llvm.org/D70456