[PATCH] D71160: [AArch64][SVE] Implement SPLAT_VECTOR for i1 vectors.

[Eli Friedman via Phabricator via llvm-commits]

efriedma marked 2 inline comments as done.
efriedma added inline comments.


================
Comment at: llvm/lib/Target/AArch64/AArch64ISelLowering.cpp:7132
   SDValue SplatVal = Op.getOperand(0);
 
   // Extend input splat value where needed to fit into a GPR (32b or 64b only)
----------------
sdesmalen wrote:
> nit: Is it worth adding a check here that the type is legal?
Given the current set of setOperationAction calls, the return type should always be legal.  Asserting that doesn't seem helpful.

The current lowering works whether or not the operand is legal.  I guess ideally, we don't want to lower operations during type legalization, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71160/new/

https://reviews.llvm.org/D71160