[PATCH] D71165: [LoopFusion] Move instructions from FC0.Latch to FC1.Latch.

Whitney Tsang via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Dec 9 12:25:46 PST 2019


Whitney added a comment.

In D71165#1774492 <https://reviews.llvm.org/D71165#1774492>, @jdoerfert wrote:

> We miss a negative test. I mean one with instruction(s) that cannot be moved.


There exists test cases that contains instructions which cannot be moved, e.g. dep_free() in simple.ll. I will add more CHECKs to make sure those instructions are not moved.

> I find it odd to add the same code twice. Please put it in helper functions.

In https://reviews.llvm.org/D65464, @kbarton said he will clean up the similar code between performFusion() and fuseGuardedLoops() in later patches, that's why I left it as duplication. I will still put my new code in helper functions anyways.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71165/new/

https://reviews.llvm.org/D71165





More information about the llvm-commits mailing list