[PATCH] D70562: [LiveRegUnits] Add phys_regs_and_masks iterator range (NFC).

Mon Dec 9 11:11:42 PST 2019

fhahn marked an inline comment as done.
fhahn added inline comments.

================
Comment at: llvm/lib/CodeGen/LivePhysRegs.cpp:47
-    if (O->isReg()) {
-      if (!O->isDef() || O->isDebug())
-        continue;
----------------
paquette wrote:
> In this patch, we don't have an equivalent check to `O->isDebug()`. Instead, all we have is a check for `MOP.isDef()`.
> 
> Do we need a similar check in the new code?
Yep, I originally thought that Debug operands cannot also be physical registers, but given that all the existing places check for it I guess its safer to explicitly filter them out. I've update the patch ( and also added a comment to phys_regs_and_masks)

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70562/new/

https://reviews.llvm.org/D70562