[PATCH] D70660: Add initial tests for update_{llc,cc}_test_checks.py

[Alexander Richardson via Phabricator via llvm-commits]

arichardson marked 2 inline comments as done.
arichardson added inline comments.


================
Comment at: llvm/test/tools/UpdateTestChecks/lit.local.cfg:6
+
+# python 2.7 backwards compatibility
+try:
----------------
MaskRay wrote:
> What's the status of Python 3 compatibility of lit? Can we skip the tests if the legacy Python 2 is used?
lit works with python3. However, the default is still to run lit with python2.7 and I would like these tests to always run rather than only for those who configure LLVM with `DPYTHON_EXECUTABLE=/usr/bin/python3`


================
Comment at: llvm/test/tools/UpdateTestChecks/lit.local.cfg:48
+if py3_exe:
+    config.substitutions.append(('%python3', '\'' + py3_exe + '\''))
+    config.available_features.add('python3')
----------------
MaskRay wrote:
> `'\''` -> `"'"`
> 
> Why isn't this `shell_quote`?
Will fix, I added this line before realizing that I needed more things to be quoted.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70660/new/

https://reviews.llvm.org/D70660