[PATCH] D70497: [DBG] Teach DebugEntityHistoryCalculator about Kill instructions.

[Vedant Kumar via Phabricator via llvm-commits]

vsk added inline comments.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DbgEntityHistoryCalculator.cpp:265
 
-      if (MI.isDebugInstr())
+      if (MI.isDebugInstr() || MI.isKill())
         continue;
----------------
aprantl wrote:
> this needs a comment. I don't really understand the reasoning in the patch description either, so if you could explain why this is safe/correct, that would help me!
@TWeaver apologies for the reverse-ping, but I'm also having some trouble following this and think that an explanatory comment would help.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70497/new/

https://reviews.llvm.org/D70497