[PATCH] D71184: [X86] Add supports for strict float operation fpextend/fpround/fsqrt

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

LGTM with those two comments addressed.



================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:627
+  setOperationAction(ISD::STRICT_FP_EXTEND, MVT::f64, Legal);
+  // FIXME: When the target is 64-bit, STRICT_FP_ROUND will
+  // be overwritten as Custom.
----------------
I don't think this FIXME is needed.


================
Comment at: llvm/lib/Target/X86/X86ISelLowering.cpp:633
+  setOperationAction(ISD::STRICT_FSQRT,    MVT::f64, Legal);
   // We don't support FMA.
   setOperationAction(ISD::FMA, MVT::f64, Expand);
----------------
Please add back the blank line that was here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71184/new/

https://reviews.llvm.org/D71184