[PATCH] D71202: [test][llvm-cxxfilt] Fix darwin build bot/improve test naming and commenting

[George Rimar via Phabricator via llvm-commits]

grimar added a comment.

LG. I have only a single suggestion.



================
Comment at: llvm/test/tools/llvm-cxxfilt/simple.test:9
 RUN:   | FileCheck %s --check-prefix=CHECK-STRING
-RUN: llvm-cxxfilt "CLI remains mangled _Z1fi" \
+RUN: llvm-cxxfilt -n "CLI remains mangled _Z1fi" \
 RUN:   | FileCheck %s --check-prefix=CHECK-MANGLED
----------------
It is probably not obvious that "-n" is the same as `--strip-underscore` (help text does not show it).
(When I read "Note that this test uses "-n" because on darwin, the default for --strip-underscore is true"
I wasn't sure if `-n` is the same as `--strip-underscore` or it was a mistype/copy-paste error)

I'd try stick to the options that are listed in a help text in out tests probably.




Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71202/new/

https://reviews.llvm.org/D71202