[PATCH] D71070: [llvm-dwarfdump][Statistics] Don't count coverage less than 1% as 0%

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 8 23:29:18 PST 2019


djtodoro added a comment.

In D71070#1774443 <https://reviews.llvm.org/D71070#1774443>, @dblaikie wrote:

> In D71070#1774223 <https://reviews.llvm.org/D71070#1774223>, @krisb wrote:
>
> > @djtodoro , yeah, it doesn't look good.
> >  I also considered an option to rename the first bucket to smth like "No location info" or "Not covered" or something similar then the second can be safely named '0-9%'. 
> >  Or simply to use '0-9%' together with '0%' which might be a bit unclear, but as docs say 'The line 0% shows the number and the percentage of DIEs with no location information', it should not be confusing.
>
>
> does this bucket include 9%? I guess the next bucket starts at 10%, so 0-9 includes 9.99%? so technically this one is (0, 10)% and the next one is [10, 91)% etc... (or I guess you could put the % inside the braces/parens)? but that might be insufficiently obvious to read?


I am also thinking about combination of the `[/]` and `(/)`. That will clarify things here.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71070/new/

https://reviews.llvm.org/D71070





More information about the llvm-commits mailing list