[PATCH] D71178: [x86] Don't assume sign-extension of arguments smaller than 32-bits.

[Emilio Cobos Álvarez via Phabricator via llvm-commits]

emilio marked an inline comment as done.
emilio added a comment.

In D71178#1774433 <https://reviews.llvm.org/D71178#1774433>, @craig.topper wrote:

> Shouldn’t we instead stop the sext and zext attributes from being added by the frontend?


Heh, yeah, I was just going to comment on that, here's my WIP comment:

> While I looked through more tests.I think this patch, even though it produces the expected behavior, is wrong... In particular, it seems clang is generating ir with the `zeroext` / `signext` annotation, and _that_ is the thing to fix, not this, which just disables the optimization the annotation enables.
>  (I think. My llvm-foo is not the strongest)

So yeah, I think you're right. I'll look into where does clang generate this. Thanks!


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71178/new/

https://reviews.llvm.org/D71178