[PATCH] D71178: [x86] Don't assume sign-extension of arguments smaller than 32-bits.

Emilio Cobos Álvarez via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Dec 8 17:00:32 PST 2019


emilio marked an inline comment as done.
emilio added inline comments.


================
Comment at: llvm/test/CodeGen/X86/x86-64-arg.ll:1
-; RUN: llc < %s | grep "movl	%edi, %eax"
-; The input value is already sign extended, don't re-extend it.
----------------
xbolva00 wrote:
> Why deleted? You can update it: Replace this line with:
> 
> ; RUN: llc < %s -mtriple=x86_64-unknown-unknown | FileCheck %s
> 
> and run:
> utils/update_llc_test_checks.py llvm/test/CodeGen/X86/x86-64-arg.ll
This was testing exactly for the wrong assumption, so it seemed like it was not worth keeping. But I'm happy to update it if you prefer.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71178/new/

https://reviews.llvm.org/D71178





More information about the llvm-commits mailing list