[PATCH] D71177: [ValueTracking] Use the assumption that if the pointer was loaded/stored, then it is nonnull.
Danila Kutenin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Dec 8 13:12:00 PST 2019
danlark added a comment.
In D71177#1774369 <https://reviews.llvm.org/D71177#1774369>, @lebedev.ri wrote:
> In D71177#1774366 <https://reviews.llvm.org/D71177#1774366>, @danlark wrote:
>
> > In D71177#1774364 <https://reviews.llvm.org/D71177#1774364>, @lebedev.ri wrote:
> >
> > > There were behavior-changing alterations, but no test changes?
> >
> >
> > If I understand correctly, yes.
>
>
> It was another way of saying: "there's no test coverage for that change, it'll break and no one will notice until it miscompiles, tests should be added"
test_null_after_{load,store} fail without that change
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71177/new/
https://reviews.llvm.org/D71177
More information about the llvm-commits
mailing list