[PATCH] D70781: AMDGPU: Fix handling of infinite loops in fragment shaders
Nicolai Hähnle via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Dec 8 10:45:04 PST 2019
nhaehnle added a comment.
This mostly looks good, except I strongly suspect that all other export intrinsics should have their done bit set to 0 in this case.
If two exports with done bit are executed, I suspect we could enter race conditions where the export allocation is freed after the first export with done, and then another wave gets the same export memory spot and its data could be overwritten by the second, newly introduced, export with done bit. Or enter some hang condition in the hardware. Who knows.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70781/new/
https://reviews.llvm.org/D70781
More information about the llvm-commits
mailing list