[PATCH] D70562: [LiveRegUnits] Add phys_regs_and_masks iterator range (NFC).

Jessica Paquette via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 6 16:16:43 PST 2019


paquette added inline comments.


================
Comment at: llvm/lib/CodeGen/LivePhysRegs.cpp:47
-    if (O->isReg()) {
-      if (!O->isDef() || O->isDebug())
-        continue;
----------------
In this patch, we don't have an equivalent check to `O->isDebug()`. Instead, all we have is a check for `MOP.isDef()`.

Do we need a similar check in the new code?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70562/new/

https://reviews.llvm.org/D70562





More information about the llvm-commits mailing list