[PATCH] D70026: [cmake] Always build the libLLVM shared library
Saleem Abdulrasool via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 6 15:21:13 PST 2019
compnerd added inline comments.
================
Comment at: llvm/CMakeLists.txt:655-656
if(WIN32 OR CYGWIN)
- if(BUILD_SHARED_LIBS OR LLVM_BUILD_LLVM_DYLIB)
+ if(BUILD_SHARED_LIBS)
set(LLVM_ENABLE_PLUGINS_default ON)
----------------
tstellar wrote:
> compnerd wrote:
> > tstellar wrote:
> > > This change I'm not so sure about. Can we drop the WIN32 part of the condition? Does CYGWIN support building shared libs?
> > Why the desire to drop `WIN32`? Both Windows and cygwin support shared libraries.
> I just wasn't sure what WIN32 meant. Does it mean all of windows or just 32-bit windows? I'm fine with keeping it.
Yes, it means all windows builds.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70026/new/
https://reviews.llvm.org/D70026
More information about the llvm-commits
mailing list