[PATCH] D71128: [NVPTX][FIX] Expand atomics we cannot handle natively in the ISA

Johannes Doerfert via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 6 15:02:20 PST 2019


jdoerfert added a comment.

In D71128#1773447 <https://reviews.llvm.org/D71128#1773447>, @tra wrote:

>   > Command Output (stderr):
>   > --
>   > /mnt/disks/ssd0/agent/workspace/amd64_debian_testing_clang8/llvm/test/CodeGen/NVPTX/atomics-sm60.ll:6:10: error: CHECK: expected string not found in input
>   > ; CHECK: atom.add.f64
>   >          ^
>   > <stdin>:1:1: note: scanning from here
>   > //
>   > ^
>   > <stdin>:34:2: note: possible intended match here
>   >  atom.cas.b64 %rd3, [%r1], %rd2, %rd1;
>   >  ^
>   
>   
>
> This appears to be a regression. We do have fp32/fp64 atomic adds in NVPTX. Replacing them with add+CAS is suboptimal.


I'm already working on it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71128/new/

https://reviews.llvm.org/D71128





More information about the llvm-commits mailing list