[PATCH] D71148: [hwasan] Offline symbolization script.

[Evgenii Stepanov via Phabricator via llvm-commits]

eugenis marked 2 inline comments as done.
eugenis added inline comments.


================
Comment at: compiler-rt/lib/hwasan/scripts/hwasan_symbolize:1
+#!/usr/bin/env python
+#===- lib/hwasan/scripts/hwasan_symbolize ----------------------------------===#
----------------
hctim wrote:
> Should this file be `hwasan_symbolize.py`?
it's installed in bin/, and we don't really want a .py extension there


================
Comment at: compiler-rt/lib/hwasan/scripts/hwasan_symbolize:239
+if not symbolizer_path:
+  candidates = glob.glob('/usr/bin/llvm-symbolizer-*')
+  def extract_version(s):
----------------
hctim wrote:
> Shouldn't we be getting this from user PATH instead? For me , `which llvm-symbolizer` returns `/usr/local/bin/llvm-symbolizer` (which is the default install path for `ninja install` IIRC).
fixed


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71148/new/

https://reviews.llvm.org/D71148