[PATCH] D70859: [BUG-FIX][XCOFF] fixed a bug of XCOFFObjectFile.cpp when there is padding at the last csect of a sections
David Tenty via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Fri Dec 6 13:58:46 PST 2019
daltenty added inline comments.
================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:353
const MCAsmLayout &Layout) {
- uint32_t CurrentAddressLocation = 0;
+ uint32_t CurrentAddressLocation;
for (const auto *Section : Sections) {
----------------
This can be merged into the loop body now
================
Comment at: llvm/lib/MC/XCOFFObjectWriter.cpp:359
- assert(CurrentAddressLocation == Section->Address &&
- "We should have no padding between sections.");
+ CurrentAddressLocation = Section->Address;
for (const auto *Group : Section->Groups) {
----------------
Combine this with the declaration
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D70859/new/
https://reviews.llvm.org/D70859
More information about the llvm-commits
mailing list