[PATCH] D70738: [libFuzzer] Add custom output function

[Nick Fitzgerald via Phabricator via llvm-commits]

fitzgen added a comment.

Thanks for the in-depth replies, @kcc and @vitalybuka.

> will cause an arbitrarily large input to be printed to stderr

If someone sets this hook, then they *want* those logs, so I see this as working as expected, and not as something to be concerned about.

I suppose that if you are for some reason running someone else's fuzzer, perhaps you wouldn't want those logs? Could this (seemingly less common) use case be supported with a `-disable-custom-output` flag or something of the sort?

> I'd prefer to not overload the public interface

I hope that this concern can be alleviated by

1. the tiny size of this patch, which shows that it is not an invasive change and should not be a burden to maintain going forward, and

2. the conceptual congruence it has with the existing custom mutation hook support.

Furthermore, it seems like having everyone with this use case write their own wrapper script sums to more of a total maintenance burden than accepting this patch and solving the issue for everyone once and for all.

But yes, there is no getting around the fact that this patch adds to the public interface, and if keeping that small is the absolute highest priority, then we can go back to the drawing board.


Repository:
  rCRT Compiler Runtime

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70738/new/

https://reviews.llvm.org/D70738