[PATCH] D71145: [InstCombine] Allow to limit the max number of iterations

Jakub Kuderski via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 6 12:43:30 PST 2019


kuhar created this revision.
kuhar added reviewers: fhahn, davide, spatel, foad, nlopes.
Herald added a subscriber: hiraditya.
Herald added a reviewer: grosser.
Herald added a project: LLVM.

This patch teaches InstCombine to accept a new parameter: maximum number of iterations over functions.

InstCombine tries to simplify instructions by iterating over the whole function until the function stops changing. As a consequence, the last iteration before reaching a fixpoint visits all instructions in the worklist and never performs any rewrites.

Bounding the number of iterations can have 2 benefits:

- In case the users of the pass can make a good guess about the number of required iterations, we can save the time normally spent on the last iteration that doesn't change anything.
- When the wants to use InstCombine as a cleanup pass, it may be enough to run just a few iterations and stop even before reaching a fixpoint. This can be also useful for implementing a lightweight pass pipeline (think `-O1`).

This patch does not change the behavior of opt or Clang -- limiting the number of iterations is entirely opt-in.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D71145

Files:
  llvm/include/llvm/Transforms/InstCombine/InstCombine.h
  llvm/lib/Transforms/InstCombine/InstructionCombining.cpp
  llvm/test/Transforms/InstCombine/limit-max-iterations.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D71145.232630.patch
Type: text/x-patch
Size: 7923 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20191206/75bc8bf3/attachment.bin>


More information about the llvm-commits mailing list