[PATCH] D71131: gn build: Change scudo's list of supported platforms to a whitelist.

Nico Weber via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Dec 6 11:18:32 PST 2019


thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

Thanks! lg.

I'd probably find it easier to understand, or at least more self-consistent, if this file had an assert(is_linux || is_fuchsia), and llvm/utils/gn/secondary/BUILD.gn had just the dep on //compiler-rt it already had, and the supported_toolchain stuff in this file wasn't here and instead relied on secondary/compiler-rt/BUILD.gn, and secondary/compiler-rt/lib/BUILD.gn would add a dep to scudo only if target_os == linux || fuchsia.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71131/new/

https://reviews.llvm.org/D71131





More information about the llvm-commits mailing list