[PATCH] D71106: [MC] Delete MCCodePadder

[Philip Reames via Phabricator via llvm-commits]

reames added a comment.

LGTM w/minor comment addressed before submit.



================
Comment at: llvm/lib/Target/Mips/MipsAsmPrinter.cpp:469
 void MipsAsmPrinter::EmitBasicBlockEnd(const MachineBasicBlock &MBB) {
-  AsmPrinter::EmitBasicBlockEnd(MBB);
   MipsTargetStreamer &TS = getTargetStreamer();
----------------
The base class method still exists, so please leave this line.


================
Comment at: llvm/lib/Target/X86/X86AsmPrinter.h:133
   void EmitBasicBlockEnd(const MachineBasicBlock &MBB) override {
-    AsmPrinter::EmitBasicBlockEnd(MBB);
     SMShadowTracker.emitShadowPadding(*OutStreamer, getSubtargetInfo());
----------------
Same.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71106/new/

https://reviews.llvm.org/D71106