[PATCH] D71093: [InstCombine] Insert instructions before adding them to worklist

[Sanjay Patel via Phabricator via llvm-commits]

spatel added a comment.

In D71093#1772839 <https://reviews.llvm.org/D71093#1772839>, @lebedev.ri wrote:

> I'm not convinced this is an improvement overall.
>
> As a concrete point: we will no longer print the 'new' if said 'new' isn't a new instruction;
>  as in, printing of new will now depend on the fact that it will be added into worklist,
>  which won't be the case if we returned preexisting instruction.


If we return the existing instruction, don't we always fall down to the else at line 3372 and print it there?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71093/new/

https://reviews.llvm.org/D71093