[PATCH] D71109: [ARM] Disable VLD4 under MVE

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: llvm/test/Transforms/LoopVectorize/ARM/mve-vldn.ll:4
+; RUN: opt -loop-vectorize -mve-max-interleave-factor=2 < %s -S -o - | FileCheck %s --check-prefixes=CHECK,CHECK-2,CHECK-NO4
+; RUN: opt -loop-vectorize -mve-max-interleave-factor=4 < %s -S -o - | FileCheck %s --check-prefixes=CHECK,CHECK-2,CHECK-4
+
----------------
dmgreen wrote:
> SjoerdMeijer wrote:
> > Perhaps silly question, but what happens when we pass `-mve-max-interleave-factor=42`, i.e. a value > 4? Is input checked? Do we need to mention that acceptable values are 1, 2, and 4?
> I was going for not caring about the internal compiler options being given strange values. I think it would likely hit an assert if you put it too high. Hopefully something we don't need to worry about in any case?
> 
> The nice thing about an option like this is that we can also set it to 1 if we need to disable the vldn's entirely.
Agreed.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71109/new/

https://reviews.llvm.org/D71109