[PATCH] D69999: [DebugInfo] Support for DW_OP_implicit_pointer (IR Verifier and Bitcode)

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicInst.h:128
+    bool isImplicitPointer() const {
+      if (!isa<DIExpression>(getRawExpression()))
+        return false;
----------------
I think this check is unnecessary - it seems like this is expected to be true for every DbgVariableIntrinsic, and this check isn't used anywhere else prior to calling getExpression().


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DebugLocEntry.h:45
 
   /// Or a location in the machine frame.
   MachineLocation Loc;
----------------
Nit: the full stop should be replaced by a comma, and the comment immediately below should end with a full stop.


================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfCompileUnit.h:135
+      return ImplicitVars.size() - 1;
+    } else
+      return std::distance(ImplicitVars.begin(), It);
----------------
The "else" can be removed, since the if block ends with a return statement.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69999/new/

https://reviews.llvm.org/D69999