[PATCH] D71101: [lld][RISCV] Use an e_flags of 0 if there are only binary input files.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 5 18:16:08 PST 2019


MaskRay added inline comments.


================
Comment at: lld/ELF/Arch/RISCV.cpp:109
 uint32_t RISCV::calcEFlags() const {
-  assert(!objectFiles.empty());
+  if (objectFiles.empty())
+    return 0;
----------------
For reasonable change that applies to other targets as well, we should try making them generic.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71101/new/

https://reviews.llvm.org/D71101





More information about the llvm-commits mailing list