[PATCH] D70877: [WebAssebmly][MC] Support .import_name/.import_field asm directives

Sam Clegg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 5 14:35:52 PST 2019


sbc100 marked an inline comment as done.
sbc100 added inline comments.


================
Comment at: llvm/test/MC/WebAssembly/import-module.s:13
+  .import_module  foo, bar
+  .import_name  foo, qux
+
----------------
sbc100 wrote:
> dschuff wrote:
> > What should happen if there's a directive that refers to a symbol that doesn't exist in the asm file?
> I seems that it does the same thing we do for `.functype` above, basically nothing.
To be a little more specific it seems that for these kind of attributes we call `Ctx.getOrCreateSymbol` then set a propoerty of the symbol, but if that symbol isn't used elsewhere it isn't included in the output.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70877/new/

https://reviews.llvm.org/D70877





More information about the llvm-commits mailing list