[PATCH] D69178: [DebugInfo] Use DBG_VALUEs IsIndirect field for describing stack spills
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Dec 5 09:46:08 PST 2019
aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:1534
+ SmallVector<uint64_t, 2> Ops = {dwarf::DW_OP_deref_size, Size};
+ DIExpr = DIExpression::prependOpcodes(DIExpr, Ops);
+ } else {
----------------
Nit: assuming that prependOpcodes takes an ArrayRef, a `uint64 Ops[] = {dwarf::DW_OP_deref_size, Size};` seems sufficient here?
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D69178/new/
https://reviews.llvm.org/D69178
More information about the llvm-commits
mailing list