[PATCH] D71088: [DA] Improve dump to show source and sink of the dependence

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/lib/Analysis/DependenceAnalysis.cpp:198
             OS << "none!\n";
+          OS << "  Src:" << *SrcI << " --> Dst:" << *DstI << "\n";
         }
----------------
Printing that last seems a bit odd to me. How about moving it up and have something like `"da analyze - Src" << *SrcI << " --> Dst :" << *DstI`?


================
Comment at: llvm/test/Analysis/DependenceAnalysis/Dump.ll:19
+; CHECK:  Src:  store {{.*}} --> Dst:  call {{.*}}
+; CHECK:  Src:  call {{.*}} --> Dst:  call {{.*}}
+
----------------
Please check the complete output (should not be too much in the case) and it helps with getting the complete picture of the changed output.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71088/new/

https://reviews.llvm.org/D71088