[PATCH] D70984: [ThinLTO] Add option to disable readonly/writeonly attribute propagation

[Teresa Johnson via Phabricator via llvm-commits]

tejohnson marked 2 inline comments as done.
tejohnson added inline comments.


================
Comment at: llvm/lib/IR/ModuleSummaryIndex.cpp:166
+    bool ImportEnabled) {
+  setWithAttributePropagation();
+
----------------
steven_wu wrote:
> Do we still need to drop all the readonly writeonly flag if simply return before `setWithAttributePropagation()`?
Good point, this code predated having the WithAttributePropagation flag on the index, which gates its use. I stripped this stale code out, and moved the check of the ImportEnabled back to the caller. I am still moving the setting of the WithAttributePropagation flag into propagateAttributes where I think it makes more sense.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70984/new/

https://reviews.llvm.org/D70984