[PATCH] D70622: [cmake][lit] Follow symlinks when looking for lit tests & reconfigure lldb's tests.

Jordan Rupprecht via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 5 12:47:13 PST 2019


rupprecht added a comment.

In D70622#1765674 <https://reviews.llvm.org/D70622#1765674>, @JDevlieghere wrote:

> No objections to moving the test. Jordan, let me know if you're up for it, otherwise I'm happy to take care of it.


I tried moving it today. The rabbit hole goes deep :D
The test framework seems pretty tied to the directory layout (because python), e.g. those must be in a directory called "lldbsuite" to be able to "import lldbsuite"
The test infrastructure also seems to assume tests + test framework are in the same tree (e.g. the LLDB_TEST env var is used for both), so moving the individual test directories and leaving just the framework classes in lldbsuite breaks a few things.

I agree it's probably cleaner to move the tests, so I'll keep poking. Suggestions welcome though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70622/new/

https://reviews.llvm.org/D70622





More information about the llvm-commits mailing list