[PATCH] D70942: [LegalizeTypes] Bugfixes for big-endian targets when handling BITCASTs

Sanjay Patel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Dec 5 11:21:09 PST 2019


spatel added inline comments.


================
Comment at: llvm/test/CodeGen/ARM/legalize-bitcast.ll:1
+; RUN: llc -O0 -mtriple=armebv7 -target-abi apcs -o - %s -stop-before=finalize-isel | FileCheck %s
+
----------------
The bug is still visible if you let this RUN all the way to asm output, right?
If so, I think that would be easier to read, especially if we can auto-generate the CHECK lines using "utils/update_llc_test_checks.py".
Either way, I think it's better to pre-commit this test to trunk showing the wrong output. That way, this patch will show the diff that creates the correct code. (And if for some reason this patch needs to be reverted, it will be clear that we have reverted to code that creates a miscompile.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70942/new/

https://reviews.llvm.org/D70942





More information about the llvm-commits mailing list