[PATCH] D70456: [Matrix] Add first set of matrix intrinsics and initial lowering pass.

[Gerolf Hoflehner via Phabricator via llvm-commits]

Gerolf added a comment.

LGTM.



================
Comment at: llvm/lib/Transforms/Scalar/LowerMatrixIntrinsics.cpp:45
+// the start address of column \p Col with type (\p EltType x \p NumRows)
+// assuming \p Stride elements between the end and start of two consecutive
+// columns.
----------------
Nit: \p Stride elements. You can delete the rest since you repeat the Stride definition below.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70456/new/

https://reviews.llvm.org/D70456